Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E] PullRequestList.InvalidateCodeComments: find code comments: needs a pointer to a slice or a map #23110

Closed
wxiaoguang opened this issue Feb 24, 2023 · 0 comments · Fixed by #23115
Closed

[E] PullRequestList.InvalidateCodeComments: find code comments: needs a pointer to a slice or a map #23110

wxiaoguang opened this issue Feb 24, 2023 · 0 comments · Fixed by #23115
Assignees
@lunny
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.19.0

Comments

@wxiaoguang
Copy link
Contributor

Description

...ervices/pull/pull.go:245:func1() [E] PullRequestList.InvalidateCodeComments: find code comments: needs a pointer to a slice or a map

It seems cause by incorrect generic call:

InvalidateCodeComments:

var codeComments []*issues_model.Comment
db.Find(ctx, ..., &codeComments)

Gitea Version

1.18/main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

N/A

Database

None
@lunny lunny self-assigned this Feb 24, 2023
@lunny lunny mentioned this issue Feb 24, 2023
Merged
@lunny lunny added this to the 1.19.0 milestone Feb 24, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 24, 2023
lunny added a commit that referenced this issue Feb 24, 2023
@lunny
Fix db.Find bug (#23115)
a8c4f8c 
Caused by #20821 

Fix #23110
@yardenshoham yardenshoham mentioned this issue Feb 24, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 24, 2023
@lunny @yardenshoham
Fix db.Find bug (go-gitea#23115)
635b67f 
Caused by go-gitea#20821 

Fix go-gitea#23110
zeripath pushed a commit that referenced this issue Feb 24, 2023
@yardenshoham
Fix db.Find bug (#23115) (#23119)
27e3071 
Backport #23115

Caused by #20821 

Fix #23110
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lunny lunny

Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging a pull request may close this issue.

Fix db.Find bug lunny/gitea
2 participants
@lunny @wxiaoguang