-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad HTML encoding in blames #17492
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
type/bug
Milestone
Comments
The |
I think it is a double-encoding bug. Can you share the existing reproducible URL on try.gitea.io? Then developers can view the bug at first glance. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Oct 31, 2021
The call to html.EscapeString in routers/web/repo/blame.go:renderBlame is extraneous as the commit message is now rendered by the template. The template will correctly escape strings - therefore we are currently double escaping. This PR fixes this. Fix go-gitea#17492 Signed-off-by: Andrew Thornton <[email protected]>
lafriks
pushed a commit
that referenced
this issue
Oct 31, 2021
The call to html.EscapeString in routers/web/repo/blame.go:renderBlame is extraneous as the commit message is now rendered by the template. The template will correctly escape strings - therefore we are currently double escaping. This PR fixes this. Fix #17492 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Oct 31, 2021
Backport go-gitea#17498 The call to html.EscapeString in routers/web/repo/blame.go:renderBlame is extraneous as the commit message is now rendered by the template. The template will correctly escape strings - therefore we are currently double escaping. This PR fixes this. Fix go-gitea#17492 Signed-off-by: Andrew Thornton <[email protected]>
wxiaoguang
pushed a commit
that referenced
this issue
Oct 31, 2021
Backport #17498 The call to html.EscapeString in routers/web/repo/blame.go:renderBlame is extraneous as the commit message is now rendered by the template. The template will correctly escape strings - therefore we are currently double escaping. This PR fixes this. Fix #17492 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
The call to html.EscapeString in routers/web/repo/blame.go:renderBlame is extraneous as the commit message is now rendered by the template. The template will correctly escape strings - therefore we are currently double escaping. This PR fixes this. Fix go-gitea#17492 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
type/bug
Gitea Version
1.15.6
Git Version
2.33.1
Operating System
Arch Linux
How are you running Gitea?
Using gitea official builds from dl.gitea.io/gitea. It's the gitea-1.15.6-linux-amd64 executable.
Database
SQLite
Can you reproduce the bug on the Gitea demo site?
Yes, here : https://try.gitea.io/issuereporter287/repo
Log Gist
No response
Description
Reproduction :
<
,>
or'
Result : the special characters of the commit text are badly encoded on the blame page.
I tested by commiting
<yes> l'apo
. It is displayed as<yes> l'apo
on the web page.Screenshots
The text was updated successfully, but these errors were encountered: