-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oauth applications show up as failed logins when using ldap #16235
Comments
What version of gitea are you using? |
But in any case I see the issue. Line 859 in b223d36
should be debug unless the error is not a UserNotExist error. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jun 23, 2021
Instead log these at debug - with warn logging for other errors. Fix go-gitea#16235 Signed-off-by: Andrew Thornton <[email protected]>
Now interestingly if this user had properly authenticated these shouldn't have ever got to the UserSignin stage so I'm not sure what's going on - likely this is related to the other oauth2 error people have been experiencing. |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jun 23, 2021
Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
that referenced
this issue
Jun 23, 2021
Instead log these at debug - with warn logging for other errors. Fix #16235 Signed-off-by: Andrew Thornton <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this issue
Aug 10, 2021
…itea#16238) Instead log these at debug - with warn logging for other errors. Fix go-gitea#16235 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a lot of logs like this:
Where the key 3b5ade80-xxx is actually an oauth key (used by droneci).
It is a bit inconvenient, because the large volume hides real issues. It would be better to show this warning only if the login is not found as a token either.
The text was updated successfully, but these errors were encountered: