Blame table changing L# in URL to "undefined" rather than highlighting desired line

[richmahn]

• Gitea version (or commit ref): 6a1a633 (master)
• Git version: 2.19.0
• Operating system: N/A
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL): https://try.gitea.io/richmahn/hbo_uhb/blame/branch/master/16-NEH.usfm#L875
  • No
  • Not relevant
• Log gist:

Description

When viewing a file in the blame page via a URL that has the desired line # to highlight, it goes to that line number but then after the file load (large file) it changes the URL argument to "undefined" and never highlights the desired line.

https://try.gitea.io/richmahn/hbo_uhb/blame/branch/master/16-NEH.usfm#L875

results in

https://try.gitea.io/richmahn/hbo_uhb/blame/branch/master/16-NEH.usfm#undefined

and then after a few seconds, it goes back to the top of the list, losing its place at line 875.

Actually going to a file with no Line # in the URL and then clicking on a line # also results in "undefined" in the URL rather than the line #:

Example:
https://try.gitea.io/richmahn/hbo_uhb/blame/branch/master/manifest.yaml
click on a line number

In a version of Gitea running v1.12.4 (our production version), it works, yet the CSS styling of the lines don't match up, so we were looking at v1.13.x development branch:

https://git.door43.org/unfoldingword/hbo_uhb/blame/branch/master/16-NEH.usfm#L875

Screenshots

[6543]

did it ever worked on blame view?

[richmahn]

@6543 yes, see link to my production copy of v1.12.4 of Gitea: https://git.door43.org/unfoldingword/hbo_uhb/blame/branch/master/16-NEH.usfm#L875

Maybe bad example, as that links to a large file. Try this:
https://git.door43.org/unfoldingword/hbo_uhb/blame/branch/master/manifest.yaml#L10

[richmahn]

@6543 I noticed in v1.12.4 that the line numbers didn't line up with the text (My link goes to line 875 which it properly highlights, but the numbers are all out of wack), so I tried on development branch of Gitea and the line numbers are lined up but now doesn't highlight. I'll see if I can look at this if others can't.

[richmahn]

@6543 Probably due to this huge change of removing the highlight.js script: #12047

[richmahn]

@mrsdizzie Do you know if this has to do with your PR in June? Are we still allowing lines to be highlighted? So useful in showing others a problem in code.

[richmahn]

I could be wrong. Looks like it goes back to this PR which did some work to fix the problem I was noticing in 1.12.4: #11885

[mrsdizzie]

I'll take a look when I can but was not intentional to break or remove this feature -- could be just some is that need to be updated in template to match a js change.

[mrsdizzie]

Should be fixed in linked PR -- thanks for catching!