Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload timeout is 30 seconds (aka configure dropzone.js timeout) #12022

Closed
2 of 7 tasks
gramakri opened this issue Jun 22, 2020 · 1 comment · Fixed by #12024
Closed
2 of 7 tasks

Upload timeout is 30 seconds (aka configure dropzone.js timeout) #12022

gramakri opened this issue Jun 22, 2020 · 1 comment · Fixed by #12024
Labels
topic/ui Change the appearance of the Gitea UI
Milestone
1.12.2

Comments

@gramakri
Copy link
Contributor

  • Gitea version (or commit ref): 1.12.1
  • Operating system: ubuntu/cloudron
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When uploading large files, the UI timesout.

To reproduce:

  1. Set attachment.MAX_SIZE to a large value (say 100)
  2. Upload a large file, the upload times out.

Screenshots

image
@gramakri
Copy link
Contributor Author

gramakri commented Jun 22, 2020 •
edited
Loading

Debugging this a bit, it seems the timeout comes from https://github.com/enyo/dropzone/blob/b2a50bc61c55ff4f22663a6754020d967305c973/dist/dropzone.js#L190 (the default XHR timeout is 30 seconds). From what I can tell, this timeout is never set in the code below

gitea/web_src/js/index.js

Line 891 in daf6284

dz = await createDropzone($dropzone[0], {

@silverwind silverwind mentioned this issue Jun 22, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Jun 22, 2020
@silverwind
Disable dropzone's timeout
0fb18ca 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 23, 2020
@lunny lunny added this to the 1.12.2 milestone Jun 23, 2020
techknowlogick pushed a commit that referenced this issue Jun 24, 2020
@silverwind @lunny
Disable dropzone's timeout (#12024)
ec0743b 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: #10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: #12022
Fixes: #11906

Co-authored-by: Lunny Xiao <[email protected]>
silverwind added a commit to silverwind/gitea that referenced this issue Jun 24, 2020
@silverwind @lunny
Disable dropzone's timeout (go-gitea#12024)
c5e990b 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906

Co-authored-by: Lunny Xiao <[email protected]>
techknowlogick pushed a commit that referenced this issue Jun 24, 2020
@silverwind @lunny
Disable dropzone's timeout (#12024) (#12032)
d059156 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: #10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: #12022
Fixes: #11906

Co-authored-by: Lunny Xiao <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @lunny
Disable dropzone's timeout (go-gitea#12024)
0aaba3b 
Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload
still in progress. This disable that timeout again.

Ref: https://www.dropzonejs.com/#config-timeout
Ref: go-gitea#10645
Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute
Fixes: go-gitea#12022
Fixes: go-gitea#11906

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.2
Development

Successfully merging a pull request may close this issue.

Disable dropzone's timeout silverwind/gitea
2 participants
@lunny @gramakri