Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable key algo in ssh.minimum_key_sizes #11634

Closed
CirnoT opened this issue May 26, 2020 · 0 comments · Fixed by #11635
Closed

Unable to disable key algo in ssh.minimum_key_sizes #11634

CirnoT opened this issue May 26, 2020 · 0 comments · Fixed by #11635

Comments

@CirnoT
Copy link
Contributor

CirnoT commented May 26, 2020

As mentioned here #11417 (comment)

It is impossible to use -1 to disable algo for minimum key size check.

SSH.MinimumKeySizeCheck = sec.Key("MINIMUM_KEY_SIZE_CHECK").MustBool()
minimumKeySizes := Cfg.Section("ssh.minimum_key_sizes").Keys()
for _, key := range minimumKeySizes {
	if key.MustInt() != -1 {
		SSH.MinimumKeySizes[strings.ToLower(key.Name())] = key.MustInt()
	}
}
zeripath added a commit to zeripath/gitea that referenced this issue May 26, 2020
lafriks pushed a commit that referenced this issue May 28, 2020
zeripath added a commit to zeripath/gitea that referenced this issue May 28, 2020
techknowlogick added a commit that referenced this issue May 28, 2020
#11662)

Backport #11635

Fix #11634

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant