Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken wiki preview #11540

Closed
2 of 7 tasks
luwol03 opened this issue May 21, 2020 · 0 comments · Fixed by #11546
Closed
2 of 7 tasks

Broken wiki preview #11540

luwol03 opened this issue May 21, 2020 · 0 comments · Fixed by #11546
Labels
type/bug

Comments

@luwol03
Copy link

luwol03 commented May 21, 2020

  • Gitea version (or commit ref): 50a9727
  • Git version: 2.20.1
  • Operating system: Debian buster
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If I will link I picture in a wiki, witch I have pushed to the wiki repo, the preview is broken, like these screenshots.

Markdown code:
IMG_20200522_000411

Broken Preview:
IMG_20200522_000347

Wiki:
IMG_20200522_000329
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue May 22, 2020
@mrsdizzie
Fix images in wiki edit preview
a0915fc 
Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes go-gitea#11540
@mrsdizzie mrsdizzie mentioned this issue May 22, 2020
Merged
zeripath pushed a commit that referenced this issue May 24, 2020
@mrsdizzie
Fix images in wiki edit preview (#11546)
ae55dc7 
Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes #11540
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue May 24, 2020
@mrsdizzie
Fix images in wiki edit preview (go-gitea#11546)
2c27d2c 
Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes go-gitea#11540
zeripath pushed a commit that referenced this issue May 24, 2020
@mrsdizzie
Fix images in wiki edit preview (#11546) (#11602)
2936830 
Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes #11540
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@mrsdizzie
Fix images in wiki edit preview (go-gitea#11546)
9aebef4 
Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes go-gitea#11540
techknowlogick pushed a commit that referenced this issue Oct 16, 2020
Improve users management through the CLI (#6001) (#10492)
cb171db 
* Fix images in wiki edit preview (#11546)

Make sure wiki editor sets wiki to true so gitea renders it as a wiki page.

Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless.

Fixes #11540
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix images in wiki edit preview mrsdizzie/gitea
2 participants
@lafriks @luwol03