Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't transform quotes in Markdown #11001

Closed
silverwind opened this issue Apr 7, 2020 · 4 comments · Fixed by #11871
Closed

Don't transform quotes in Markdown #11001

silverwind opened this issue Apr 7, 2020 · 4 comments · Fixed by #11871
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

Quotes outside of code blocks (example) are currently transformed to U+201C Left Double Quotation Mark and U+201D Right Double Quotation Mark. I think this transformation is generally unwanted and confusing because it alters the original content, so I'd like to see it removed. GitHub also does not do this.
@bagasme
Copy link
Contributor

bagasme commented Apr 7, 2020

@silverwind keep the quotes as-is?

@silverwind
Copy link
Member Author

@bagasme yes that would be my preference. The less "magic" the better.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Apr 7, 2020
@guillep2k
Copy link
Member

I agree, but maybe make it optional for wikis.

@zeripath
Copy link
Contributor

Changing the default now is difficult to necessarily sign off. However, #11047 shows the way to do it.

Add a new frontmatter part:

---
gitea:
    typography: -smartQuotes
---

silverwind added a commit to silverwind/gitea that referenced this issue Jun 12, 2020
@silverwind
Disable all typographic replacements in markdown renderer
2764d98 
Previously we only disabled some of them. This disables all the default
replacements that goldmark's typographer extension offers, matching
GitHub's renderer.

Ref: https://github.com/yuin/goldmark#typographer-extension
Fixes: go-gitea#11001
@silverwind silverwind mentioned this issue Jun 12, 2020
Merged
techknowlogick added a commit that referenced this issue Jun 13, 2020
@silverwind @lafriks @techknowlogick
Disable all typographic replacements in markdown renderer (#11871)
2447ffc 
* Disable all typographic replacements in markdown renderer

Previously we only disabled some of them. This disables all the default
replacements that goldmark's typographer extension offers, matching
GitHub's renderer.

Ref: https://github.com/yuin/goldmark#typographer-extension
Fixes: #11001

* remove typographer extension completely

* fix test

* really fix test

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @lafriks @techknowlogick
Disable all typographic replacements in markdown renderer (go-gitea#1…
f670b6c 
…1871)

* Disable all typographic replacements in markdown renderer

Previously we only disabled some of them. This disables all the default
replacements that goldmark's typographer extension offers, matching
GitHub's renderer.

Ref: https://github.com/yuin/goldmark#typographer-extension
Fixes: go-gitea#11001

* remove typographer extension completely

* fix test

* really fix test

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable all typographic replacements in markdown renderer silverwind/gitea
5 participants
@lunny @silverwind @zeripath @guillep2k @bagasme