BEAKING: check return status based on struct not httpStatus

go-gitea · Apr 9, 2020 · 533f52a · 533f52a
1 parent 0be25e2
commit 533f52a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/routers/api/v1/notify/notifications.go b/routers/api/v1/notify/notifications.go
@@ -19,15 +19,6 @@ func NewAvailable(ctx *context.APIContext) {
  // summary: Check if unread notifications exist
  // responses:
  // "200":
- // "$ref": "#/responses/NotificationCount"
- // "204":
- // description: No unread notification
-
- count := models.CountUnread(ctx.User)
-
- if count > 0 {
- ctx.JSON(http.StatusOK, api.NotificationCount{New: count})
- } else {
- ctx.Status(http.StatusNoContent)
- }
+ // "$ref": "#/responses/NotificationCount"
+ ctx.JSON(http.StatusOK, api.NotificationCount{New: models.CountUnread(ctx.User)})
 }
diff --git a/templates/swagger/v1_json.tmpl b/templates/swagger/v1_json.tmpl
@@ -530,9 +530,6 @@
  "responses": {
  "200": {
  "$ref": "#/responses/NotificationCount"
- },
- "204": {
- "description": "No unread notification"
  }
  }
  }