Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Improving / Exposing Git-Trees related features for Git-Trees API. #123

Merged
merged 5 commits into from
Nov 26, 2018

Conversation

Kasi-R
Copy link

@Kasi-R Kasi-R commented Jun 8, 2018

Additions to allow/improve Git-Trees API.

  • Exposes TreeEntry.mode through TreeEntry.Mode()
  • Fixes EntryMode consts (changed to hex)
  • Added revision parsing for trees (HEAD, HEAD~1, etc).

tree_entry.go Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@578ad8f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #123   +/-   ##
========================================
  Coverage          ?   32.9%           
========================================
  Files             ?      28           
  Lines             ?    1781           
  Branches          ?       0           
========================================
  Hits              ?     586           
  Misses            ?    1118           
  Partials          ?      77
Impacted Files Coverage Δ
tree_entry.go 67.67% <0%> (ø)
repo_tree.go 22.72% <0%> (ø)
tree.go 53.06% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578ad8f...9cb3c44. Read the comment docs.

@lafriks lafriks merged commit 6b81917 into go-gitea:master Nov 26, 2018
@filipnavara
Copy link

The implementation of ListEntries/ListEntriesRecursive is broken. They both cache the output in the same variable. Whichever is called first returns the correct value, but calling the other one will result in incorrect result.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants