Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable users to prepare the flutter engine within docker image without building first. #214

Merged
merged 13 commits into from
Jun 20, 2021
Merged

enable users to prepare the flutter engine within docker image without building first. #214

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a35349c
create prepare-engine subcommand and use it in the dockerfile
cosban Jun 9, 2021
a02cb95
fix(deps): github.com/otiai10/[email protected]: missing go.sum entry
cosban Jun 9, 2021
6d289f1
fix(deps): go mod tidy
cosban Jun 9, 2021
35164d5
fix: swap engine prep to debug mode
cosban Jun 9, 2021
f7dba06
fix: add missing ~ to CGO_LDFLAGS
cosban Jun 9, 2021
fe516df
remove support for multiple target OSes in prepare-engine.
cosban Jun 9, 2021
69c2e01
Merge branch 'master' into master
cosban Jun 12, 2021
bf22bf8
FEAT: add profile mode
cosban Jun 20, 2021
a8f58dc
FIX: don't check for darling within prepare-engine, simply fail for d…
cosban Jun 20, 2021
aac022f
Merge branch 'master' of github.com:cosban/hover
cosban Jun 20, 2021
aa157fe
FIX: fail to prepare engine in release mode if on darwin
cosban Jun 20, 2021
d3fa616
FIX: add profile for windows and linux
cosban Jun 20, 2021
0d1052e
REQUEST: rework prepare mode validation logic
cosban Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX: fail to prepare engine in release mode if on darwin
  • Loading branch information
@cosban
cosban committed Jun 20, 2021
commit aa157fe9db6b1d7ede07d4f9e1128f6d6d60ee41
2 changes: 1 addition & 1 deletion cmd/prepare-engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func validatePrepareEngineParameters(targetOS string) {
log.Errorf("Multiple target modes set. Please select exactly one from: debug, profile, release.")
os.Exit(1)
}
if targetOS == "darwin" && runtime.GOOS != targetOS && prepareReleaseMode {
if targetOS == "darwin" && runtime.GOOS != targetOS && (prepareReleaseMode || prepareProfileMode) {
log.Errorf("It is not possible to prepare the flutter engine in release mode for darwin using docker")
os.Exit(1)
}
Expand Down