Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tolower domain by default #32

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

rfyiamcool
Copy link
Contributor

summary

I think a lowercase domain name would be better.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f70bf73) 89.04% compared to head (7bce56e) 89.04%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          12       12           
  Lines        1762     1762           
=======================================
  Hits         1569     1569           
  Misses        138      138           
  Partials       55       55           
Files Changed Coverage Δ
internet.go 80.26% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bxcodec bxcodec merged commit ab6c09f into go-faker:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants