Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- update README with correct command & output #13

Merged
merged 1 commit into from
Oct 9, 2020
Merged

- update README with correct command & output #13

merged 1 commit into from
Oct 9, 2020

Conversation

suntong
Copy link
Contributor

@suntong suntong commented Oct 8, 2020

Description

go get -v -u github.com/go-ego/gpy/tools/pinyin

$ gpy
bash: gpy: command not found

I.e..

  • gpy command is not found after doing go get github.com/go-ego/gpy/tools/pinyin
  • and its current default output do not contain 声调

@suntong
Copy link
Contributor Author

suntong commented Oct 9, 2020

Ops, found that

style = flag.String("s", "zh4ao", str)

I.e., the default is indeed should be with the tone.

But why my pinyin output that way.

Would someone double-check please?

@vcaesar vcaesar merged commit cef366d into go-ego:master Oct 9, 2020
@suntong suntong mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcaesar vcaesar vcaesar approved these changes

Assignees
No one assigned
Labels
bug hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suntong @vcaesar