Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discovery framework model #36

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Add discovery framework model #36

merged 1 commit into from
Jun 30, 2021

Conversation

little-cui
Copy link
Collaborator

No description provided.

tianxiaoliang
tianxiaoliang reviewed Jun 30, 2021
View reviewed changes
discovery/framework.go Outdated

const Unknown = "UNKNOWN"

type FrameWorkProperty struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework是个单词

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

名字叫Framework就可以了，不用指出他是个属性，很累赘

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@tianxiaoliang tianxiaoliang merged commit b9201ba into go-chassis:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianxiaoliang tianxiaoliang tianxiaoliang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@little-cui @tianxiaoliang