Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few Meson improvements #1757

Merged
merged 2 commits into from
Sep 23, 2019
Merged

A few Meson improvements #1757

merged 2 commits into from
Sep 23, 2019

Conversation

ximion
Copy link
Collaborator

@ximion ximion commented Sep 15, 2019

Tilix can actually be built with other D compilers than LDC now, so reflect that in the Meson file. Also, install the manual page (the untranslated only for now).


EXTRA_DIST = $(srcdir)/tilix $(srcdir)/po/*.man.po
EXTRA_DIST = $(srcdir)/tilix.1 $(srcdir)/po/*.man.po
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commit please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commit for what? This change is required for the manual page installation, which already is in a separate commit...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I overlooked the git history when I pulled the changes.

Copy link

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@gnunn1 gnunn1 merged commit 3818f0d into gnunn1:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants