Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParaSwap /swap API #35

Merged
merged 4 commits into from
Jun 7, 2024
Merged

ParaSwap /swap API #35

merged 4 commits into from
Jun 7, 2024

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Jun 5, 2024

Description

ParaSwap provides a private /swap API in order to send a single API call instead of two(/prices+/transactions).
This should reduce the requests amount and also simplify the code.

How to test

Local run

@squadgazzz squadgazzz marked this pull request as ready for review June 5, 2024 18:34
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 nits.
Really excited for this change! Maybe the paraswap quoter finally become useful. 😅

src/infra/dex/paraswap/mod.rs Outdated Show resolved Hide resolved
src/infra/dex/paraswap/dto.rs Outdated Show resolved Hide resolved
@squadgazzz squadgazzz enabled auto-merge (squash) June 7, 2024 09:13
@squadgazzz squadgazzz merged commit 991ff20 into main Jun 7, 2024
3 checks passed
@MartinquaXD MartinquaXD deleted the paraswap-swap-endpoint branch June 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants