Please checkout the change to enable building fcgiwrap as RPM package #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes the Makefile.in to have correct install destination directory set.
|
Sorry for taking too long with this. I'll happily merge this after #17 (will probably need a tweak with the systemd unit paths). I'd only ask you to comment about the Makefile.in change (which seems right to me but if so, how the hell did it ever build properly before?) and to flatten the fixes in your changes into the preceding commits, e.g. bbe0c14 into 81e1616 etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi gnosek,
Thank you for your excellent FastCGI tool! I use it to serve Gitolite/cgit behind Apache or nginx.
I come up .spec file to enable fcgiwrap to be built as an RPM package. It builds a systemd enabled RPM on OS like Fedora 14+, RHEL 7. The RPM on these platforms enables and start the fcgiwrap.socket. It's a lot more convenient for admin as they no longer need spawn-fcgi or equivalent.
I also updated the README to mention the systemd socket activation feature and add instructions to build the RPM package.
I have tested RPM package on CentOS 6.4, Federo 20 and Pidora (Federo 18 on Raspberry PI).
Could please take a look at this pull request and consider merge it into main line?
Thanks a lot!