feat(x/params): add lru caching #3120
Conversation
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3120 +/- ##
==========================================
- Coverage 63.79% 63.75% -0.04%
==========================================
Files 549 549
Lines 78819 79468 +649
==========================================
+ Hits 50279 50664 +385
- Misses 25150 25388 +238
- Partials 3390 3416 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
| EventSwitch events.EventSwitch // required | ||
| VMOutput io.Writer // optional | ||
| InitChainerConfig // options related to InitChainer | ||
| ParamsMaxCacheSize int // optional |
There was a problem hiding this comment.
What is the int representing? Kb? Mb? The number of items?
| @@ -7,6 +7,7 @@ import ( | |||
| "github.com/gnolang/gno/tm2/pkg/amino" | |||
| "github.com/gnolang/gno/tm2/pkg/sdk" | |||
| "github.com/gnolang/gno/tm2/pkg/store" | |||
| "github.com/golang/groupcache/lru" | |||
There was a problem hiding this comment.
Maybe this lib is more maintained than the one used: https://github.com/hashicorp/golang-lru
| if bz == nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
what is the meaning of that code? can we have nil values in our cache? why?
LRU caching uses a specified
CacheMaxSizeto limit the number of entries. Keys are immediately invalidated when a setter is called. The LRU is shared across all the getters.Fix #3023
Related with #2911