Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line parameter for http proxy #4

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

oven
Copy link
Contributor

@oven oven commented Aug 1, 2022

Add option to use an HTTP proxy server when authenticating with AD

@gm-vm
Copy link
Owner

gm-vm commented Aug 1, 2022

Do the standard http_proxy and https_proxy env variables work for you?

Something like this (you can even specify just one of the variables):

https_proxy=myhttpsproxy:1234 http_proxy=myhttpproxy:1234 openfortivpn-webview myvpnhost

@gm-vm
Copy link
Owner

gm-vm commented Aug 1, 2022

By the way, it seems that the electron app just passes everything to Chromium, so this is actually working as well:

openfortivpn-webview --proxy-server=http:https://myproxy:1234 myvpnhost

If you use npm start you have to use pass it in this way instead:

npm start myvpnhost -- --proxy-server=http:https://myproxy.com:1234

This is also what I do to pass --enable-logging --log-level=3, as shown in the README of the project.

@oven
Copy link
Contributor Author

oven commented Aug 2, 2022

I tried setting the http_proxy and https_proxy environment variables, but they don't seem to get picked up by Chromium. I tried both HTTP_PROXY, HTTPS_PROXY, http_proxy and https_proxy, and setting them to <host>:<port> and http:https://<host>:<port>. So that approach doesn't work, at least not on OS X where I tried it.

Passing --proxy-server as an argument works, so that means this is more of a documentation issue. I'll make some changes and push a new commit :)

… option

It's not neccesary to have a dedicated http-proxy option, since Chromium
already supports --proxy-server. Add documentation on how this works.
@oven
Copy link
Contributor Author

oven commented Aug 2, 2022

I also added documentation on how to use http proxy on the QT variant, but I've not been able to test that.

@gm-vm
Copy link
Owner

gm-vm commented Aug 2, 2022

Thanks for this.

I should probably simplify how the Qt app works and let callers to pass whatever they want, as it is done for Electron. Using that env variable is not that user friendly.

@gm-vm gm-vm merged commit eff1daf into gm-vm:main Aug 2, 2022
@oven oven deleted the add-proxy branch August 4, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants