Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow User to Trust A Certificate #21

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Allow User to Trust A Certificate #21

merged 4 commits into from
Jan 29, 2024

Conversation

hftsai256
Copy link
Contributor

In rare cases, the user may be unable to get around the certificate issue with the --extra-ca-certs option. This PR offers an argument to trust a (manually confirmed) certificate by offering its fingerprint.

Copy link
Owner

@gm-vm gm-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added a couple of notes.

openfortivpn-webview-electron/index.js Outdated Show resolved Hide resolved
openfortivpn-webview-electron/index.js Outdated Show resolved Hide resolved
@hftsai256
Copy link
Contributor Author

Thank you for your valuable suggestions. I have made the necessary changes to those messages. They now read much clearer.

@gm-vm gm-vm merged commit 4898b47 into gm-vm:main Jan 29, 2024
@gm-vm
Copy link
Owner

gm-vm commented Jan 29, 2024

Given that I don't think I'll need to add more stuff any time soon, I've already release version 1.2.0 with this change.

@hftsai256
Copy link
Contributor Author

I just saw your approval, and thanks for taking care of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants