Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Maint/1.1 #368

Closed
wants to merge 2 commits into from
Closed

Conversation

pavanramkumar
Copy link
Collaborator

No description provided.

@pavanramkumar
Copy link
Collaborator Author

@jasmainak i added the .zenodo.json config to this PR. not a huge fan of this approach since it's not tied to the release version and we must be careful that this file is updated at each subsequent release.

@codecov-io
Copy link

codecov-io commented Feb 23, 2020

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files           4        4           
  Lines         686      686           
  Branches      148      148           
=======================================
  Hits          513      513           
  Misses        133      133           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc79e4...f9fb9cf. Read the comment docs.

@titipata
Copy link
Collaborator

@pavanramkumar this looks good to me! thanks! I can merge it right away 👍

@@ -16,7 +16,7 @@
# Dev branch marker is: 'X.Y.devN' where N is an integer.
#

__version__ = '1.2.dev0'
__version__ = '1.1.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, we'll have to make a full release. I'd rather just do it on the maint branch.

@jasmainak
Copy link
Member

@pavanramkumar pushed commit directly to master by cherry-pick.

@jasmainak jasmainak closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants