-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tuto-03-animated-triangle.md #1934
Conversation
I got the first example working but I was not able to figure out how to pass t to the vertex shader. |
Can you keep this in sync with https://github.com/glium/glium/blob/master/examples/tutorial-03.rs ? |
Also, #1933 does not need a revert. All the PR changed was to replace Can you remove the "revert" from the title and maybe align the inline sources in the md file with tutorial-03.rs? After that, a squash would be useful. |
7ad27a6
to
f8dfac1
Compare
I see, The .rs was working but the .md was out of date. I fixed the .md to align with the source code example in a fitting way. |
@GraydenH thanks, is this ready for review? |
yeah, good to go @est31 |
1be05e6
to
f994a47
Compare
201e26e
to
64b8ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, maybe i was not clear in my last PR. My changes were not working yet.