[REFACTOR] Converts to using @handlebars/parser #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts to using the new `@handlebars/parser` package directly instead of pulling it in from handlebars.js
|
@pzuraq what is the impact here to Ember? Seems like we no longer bundle Handlebars (at least the "inliner" is removed), can you setup an integration branch on the Ember side to account for these changes? |
|
Yes, it should mean that we just need to bundle this package instead of |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts to using the new
@handlebars/parserpackage directly insteadof pulling it in from handlebars.js