Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elixir #2553

Merged
merged 50 commits into from
Apr 13, 2024
Merged

Elixir #2553

merged 50 commits into from
Apr 13, 2024

Conversation

mitchsayre
Copy link
Contributor

@mitchsayre mitchsayre commented Apr 6, 2024 •
edited
Loading

I added Elixir fixtures. Please let me know if I should fix things or if this looks good.

I was able to get all the tests passing except blns-object.json because it contained enums that had invalid characters when representing them as Elixir atoms.

@mitchsayre
Add testing for Elixir
3db9181
@mitchsayre
Copy the Python renderer code for Elixir
87bf1af
@mitchsayre
Define forbidden module and field names for Elixir
afaff96
@mitchsayre
Switch to the Ruby renderer as the base for Elixir
9ee11bb
@mitchsayre
Add Elixir fixtures
d80cb9e
@mitchsayre
Emit descriptions for Elixir structs with @moduledoc decorator
bb9090e
@mitchsayre
Enforce required attributes on Elixir structs
c3fde6f
@mitchsayre
Define Elixir struct attributes as atoms
b4b87b3
@mitchsayre
Emit typespec decorator on Elixir structs
76eb41f
@mitchsayre
Emit typespec decorator on Elixir structs
ab8839d
@mitchsayre
Configure Elixir test fixture
3ed9973
@mitchsayre
Support running Elixir test fixture
dfd0d79
@mitchsayre
Emit Elixir from_map() lines for primitive, class, map, and array att…
b80acb8 
…ributes
@mitchsayre
Emit enum types in Elixir
efe2d9e
@mitchsayre
Improve emitted enum code for Elixir
5e95718
@mitchsayre
Handle lists and enums for Elixir toDynamic fromDynamic
c6d5f67
@mitchsayre
Fix union types for @type decorator
340e527
@mitchsayre
Handle fromDynamic for array and map types
62508f7
@mitchsayre
Switch enum serialize/deserialize to encode/decode
962789a
@mitchsayre
Add attribute toDynamic for array and map types
dda4cd7
@mitchsayre
Add union type for attribute toDynamic
1ffbf81
@mitchsayre
Emit decoding pattern match for union type attribute
9d7f421
@mitchsayre
Handle cases for encoding and decoding unions
b56d877
@mitchsayre
Pattern match for class types
bb18b6c
@mitchsayre
Fix incorrect attribute setting in from_map to_map
5759fa7
@mitchsayre
Fix Atom validation so it only wraps in quotes when necessary
e39038f
@mitchsayre
Support top level arrays
02a7a14
@mitchsayre
Handle reserved words and module names
f6b66bf
@mitchsayre
Handle more attribute and pattern match cases
8dfe266
@mitchsayre
Fix MapType to and from dynamic
1065a7a
@mitchsayre
Copy link
Contributor Author

I just realized FIXTURE=schema-elixir ran the schema tests I still need to get those passing.

I can also add a new step to the test-pr workflow.

@mitchsayre
Copy link
Contributor Author

I got the unit tests for schema and graphql passing. I believe this code is now ready for review.

Description

Added working Elixir fixtures for json,schema, and graphql

Related Issue

#556

Motivation and Context

#556

How Has This Been Tested?

  • Passed the unit tests. Skipped 6 tests. Added notes in languages.ts detailing why these tests are skipped.
  • Added a step to test-pr.yaml that runs elixir,schema-elixir,graphql-elixir
  • I have tested the generated code in my own project.

@dvdsgl dvdsgl merged commit e4a4430 into glideapps:master Apr 13, 2024
25 checks passed
@dvdsgl
Copy link
Member

dvdsgl commented Apr 13, 2024

Amazing! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchsayre @dvdsgl