Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing footer in compiled slot/fill example #9

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

Deimos
Copy link
Contributor

@Deimos Deimos commented Oct 24, 2020

Hopefully this is correct - I was just reading through the docs and this was a bit confusing, I assume the <footer> is supposed to stay there since it's outside the <import> tag.

@giuseppeg
Copy link
Owner

@Deimos yes it is, good catch! Thank you!

@giuseppeg giuseppeg merged commit 1b27fc1 into giuseppeg:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants