Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json file #15

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Update package.json file #15

merged 2 commits into from
Oct 13, 2017

Conversation

alejandronanez
Copy link
Member

  • Add engines field to sugges npm 5.3.0 or greater
  • Add missing key fields in the package.json

andrewda
andrewda reviewed Oct 13, 2017
View reviewed changes
package.json
@@ -1,4 +1,7 @@
{
"engines": {
"npm": ">=5.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to specify an npm version? should we also specify a node version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify both actually. You can have npm installed on different node versions, that’s why I added only npm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright sounds good

@alejandronanez alejandronanez merged commit 48d3a46 into master Oct 13, 2017
@alejandronanez alejandronanez deleted the update-package-json branch October 13, 2017 20:01
machour
machour reviewed Oct 13, 2017
View reviewed changes
package.json
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/gitpoint/gitpoint-site"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's git-point-site (and why not point to the git-point-site point repo instead?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that one! Updated in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour left review comments

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh Awaiting requested review from housseindjirdeh

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alejandronanez @machour @andrewda