Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): Host github-markdown.css on gitpoint.co #10

Closed
wants to merge 1 commit into from

Conversation

machour
Copy link
Member

@machour machour commented Sep 18, 2017

This will be used for iOS Markdown webview instead of https://machour.idk.tn/github-markdown.css until we come up with a better solution

@andrewda
Copy link
Member

Wait – why can't this be bundled with the app? It's not super great to be downloading a 700 line CSS file over data all the time.

@machour
Copy link
Member Author

machour commented Sep 19, 2017

@andrewda I was able to call the bundled CSS in the WebView in Android using file:https:///android_assets/css/github-markdown.css, but I couldn't figure out how to do it for iOS.
I'd be really glad if you can have a look, here's the relevant line: https://github.com/gitpoint/git-point/blob/master/src/components/markdown-webview.component.js#L36

Another solution would be to simply inject the file content in a <style> tag in the generated HTML..

@andrewda
Copy link
Member

@machour I'll look into it. I've definitely done something similar in the past, but forget exactly how.

@machour
Copy link
Member Author

machour commented Oct 4, 2017

Handled differently as per Andrew's advice

@machour machour closed this Oct 4, 2017
@machour machour deleted the host-markdown-css branch October 4, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants