[local-app] Cleanup run command, apply recommended go style #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/local-app-tweaks
branch
from
91f0976
to
8c16d2e
Compare
easyCZ
commented
Mar 25, 2022
|
@mustard-mh Could you finish a review please? |
Need more input from @easyCZ about #8956 (comment) cc @akosyakov |
easyCZ
force-pushed
the
mp/local-app-tweaks
branch
from
da78929
to
27306cb
Compare
|
@mustard-mh Thanks for the review. I've incorporated your changes and split out the port acquire into a seperate method to make it a bit cleaner. |
mustard-mh
reviewed
Mar 30, 2022
| } | ||
|
|
||
| defer func() { | ||
| if closeErr := rl.Close(); closeErr != nil { | ||
| logrus.WithField("port", port).WithError(closeErr).Warn("Failed to to close listener") |
There was a problem hiding this comment.
WARN[0005] Failed to to close listener error="close tcp4 127.0.0.1:63110: use of closed network connection" port=63110
After test, we can see this warning every time. we don't need this warning (check err is closed first), because it will always appear if auth works(it will close by this one too).
mustard-mh
approved these changes
Apr 6, 2022
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
os.Tempalready produces/tmpon darwin and linux.How to test
cd components/local-app go run main.goRelease Notes