Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] don't allow blocked users to create workspaces #19990

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Jul 2, 2024

Description

Related Issue(s)

Fixes ENT-358

How to test

  • Login preview env, start and stop a workspace
  • Make you an admin with leeway run components:make-user-admin
  • Block yourself
  • See if you can create / re-start workspaces

image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/XS and removed size/S labels Jul 2, 2024
@@ -705,6 +705,9 @@ export class WorkspaceService {
runningInstances: Promise<WorkspaceInstance[]>,
): Promise<void> {
let result: MayStartWorkspaceResult = {};
if (user.blocked) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice spot! ✨

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works! ✔️

@roboquat roboquat merged commit 4dc8b36 into main Jul 2, 2024
43 checks passed
@roboquat roboquat deleted the hw/block-user branch July 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants