Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-bridge] add update cluster tls config #19975

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jun 27, 2024

Description

[ws-manager-bridge] add update cluster tls config

Related Issue(s)

Part of ENT-343

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🏁

Please either test yourself, or ask someone else to double check if you feel it'd help.

@mustard-mh
Copy link
Contributor

mustard-mh commented Jun 27, 2024

For testing I believe in this preview env, we only need to test if tls is changeable (with gpctl clusters update), then we need a dedicated cell to make sure it use gpctl well

@iQQBot
Copy link
Contributor Author

iQQBot commented Jun 27, 2024

I started a cell for testing

@iQQBot
Copy link
Contributor Author

iQQBot commented Jun 27, 2024

@iQQBot
Copy link
Contributor Author

iQQBot commented Jun 27, 2024

/unhold

@roboquat roboquat merged commit f3ceb6b into main Jun 27, 2024
46 checks passed
@roboquat roboquat deleted the pd/update-tls branch June 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants