Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer support #19725

Merged
merged 4 commits into from
May 10, 2024
Merged

Add devcontainer support #19725

merged 4 commits into from
May 10, 2024

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 9, 2024

Description

Related Issue(s)

Fixes #

How to test

There is no OIDC support yet, you need manual login gcloud by

gcloud auth login
gcloud auth application-default login

## install previewctl if not found
leeway run dev/preview/previewctl:install

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@iQQBot iQQBot changed the title [POC] devcontainer support Add devcontainer support May 10, 2024
Comment on lines +31 to +34
- name: "go"
command: ["sh", "-c", "go version | sed s/arm/amd/"]
- name: "arch"
command: ["sh", "-c", "echo amd64"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to use the same cache under arm64 as amd64.

This is safe because we've completely isolated the main branch and the other dev branches's cache and registry, so this will never affect the main build.

In addition, the following environment controls the fact that the product of using leeway build is still amd64 architecture, even if it is on the arm64 architecture

@iQQBot iQQBot marked this pull request as ready for review May 10, 2024 13:55
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can start Gitpod repo with devcontainer now 🚀

Followed How to test section, leeway run dev:preview worked like a charm too

@iQQBot
Copy link
Contributor Author

iQQBot commented May 10, 2024

/unhold

@roboquat roboquat merged commit e6e412c into main May 10, 2024
38 checks passed
@roboquat roboquat deleted the pd/test-dev-container branch May 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants