Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[db] Move redis publisher to gitpod-db WEB-621 #18275

Merged
merged 3 commits into from
Jul 25, 2023
Merged

[db] Move redis publisher to gitpod-db WEB-621 #18275

merged 3 commits into from
Jul 25, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 13, 2023 •
edited by github-actions bot
Loading

Description

Related Issue(s)

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ requested a review from a team July 13, 2023 12:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 13, 2023
@easyCZ easyCZ changed the title [db] Move redis publisher to gitpod-db [db] Move redis publisher to gitpod-db WEB-621 Jul 13, 2023
@easyCZ easyCZ force-pushed the mp/db-include-redis-client branch from 99c9193 to ef6e54d Compare July 24, 2023 08:43
@easyCZ easyCZ requested a review from a team as a code owner July 24, 2023 08:43
@easyCZ easyCZ force-pushed the mp/db-include-redis-client branch from ef6e54d to 65d089a Compare July 25, 2023 06:17
Base automatically changed from mp/db-include-redis-client to main July 25, 2023 07:47
@geropl
Copy link
Member

geropl commented Jul 25, 2023

@easyCZ Can you do the rebase and ping me again once preview is running? 🙏

@easyCZ
Copy link
Member Author

easyCZ commented Jul 25, 2023

@easyCZ Can you do the rebase and ping me again once preview is running? 🙏

done

geropl
geropl approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works ✔️

@easyCZ
Copy link
Member Author

easyCZ commented Jul 25, 2023

/unhold

@roboquat roboquat merged commit 66df7ff into main Jul 25, 2023
12 of 13 checks passed
@roboquat roboquat deleted the mp/db-include-publisher branch July 25, 2023 11:24
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @geropl @roboquat