Improved Telegram bot token rule regex and added more test cases #1404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At work we came across an edge-case where the Telegram bot token rule would match lots of XML schema definitions in which
clm12345:AgencyIdentificationCodeContentType
appears which happens be the exact same length the regex is looking for (A[a-zA-Z0-9_\-]{34}
) prefixed with the right amount of digits ([0-9]{5,16}
) . To fix it I've modified the regex to take boundaries into account and simplifieda-zA-Z0-9
parts toa-z0-9
because the entire regex is already case insensitive ((?i)
). Also added a few more test cases.Checklist: