This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Allow floating point times #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match what the available back-ends support.
To prevent potential problems with repeating decimals, e.g. 0.3333333333333.
zerowidth
added a commit
that referenced
this pull request
Jul 30, 2014
Allow floating point timings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiments we've been doing have been using the
#timingmethod to ship floating point millisecond values, and when we switched our code over to using the#time { ... }blocks, I noticed our measurements were locked to integer millsecond values and often being rounded down to 0 for sub-millisecond times.This PR changes the client to allow us to track sub-millisecond performance timing. The spec says "integers", but everything else disagrees, transmitting and storing everything as doubles:
cc @vmg @jssjr @azizshamim
If y'all approve, I'll package this gem and roll it into a PR internally.