Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the HTML sanitization whitelist #247

Merged
merged 1 commit into from
Jan 29, 2014

Conversation

mojavelinux
Copy link
Contributor

Since this information is important for understanding how AsciiDoc is rendered on GitHub, among other markup languages, I've documented the behavior as I understand it from studying the HTML sanitization filter.

@gjtorikian
Copy link
Contributor

Looks legit.

gjtorikian added a commit that referenced this pull request Jan 29, 2014
document the HTML sanitization whitelist
@gjtorikian gjtorikian merged commit fe2854a into github:master Jan 29, 2014
@bkeepers
Copy link
Contributor

Thanks!

@pdurbin
Copy link

pdurbin commented Mar 18, 2015

@mojavelinux "Fully document which HTML tags are allowed in GitHub flavored Markdown in the Readme" at #246 was closed because your commit got merged: 8ddb670#diff-04c6e90faac2675aa89e2176d2eec7d8 . Great!

But now... the list is gone from the readme again. :(

@bkeepers
Copy link
Contributor

I replaced it in #431 with a more detailed description of how GitHub renders a README. Since it's not actually this libraries responsibility to perform the sanitization, I think it makes more sense to point people to the code where it happens. It's a constant game of whack-a-mole to update it whenever the HTML Pipeline gets updated.

Let me know if you have ideas for how to improve it.

@mojavelinux
Copy link
Contributor Author

Thanks for the clarification @bkeepers. Perhaps we could emphasize (in bold or italic) the sentence that mentions it. That way, I'm sure it won't be missed.

@@ -21,6 +21,30 @@ you wish to run the library. You can also run `script/bootstrap` to fetch them a
* [.pod](https://search.cpan.org/dist/perl/pod/perlpod.pod) -- `Pod::Simple::HTML`
comes with Perl >= 5.10. Lower versions should install Pod::Simple from CPAN.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did all of this go? Where does it live now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants