Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github-markup currently eager loads markup gems when it's required. While this only takes about 100ms when testing the gem in isolation, when it's incorporated into a larger application like the GitHub rails app with a massive
$LOAD_PATH
, the time taken to load github-markup balloons out to 250-300ms.This pull request adds lazy loading to github-markup so that markup gems are only required the first time they're used. For production environments where everything should be loaded up front, I've added a
GitHub::Markup.preload!
method that eager loads all markup gems straight away.cc @github/perf