Added package-lock.json for Node.js Tools for Visual Studio #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Application of the change: Node.js Tools for Visual Studio * Documentation about package-lock.json: https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json * Change made: package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. That is why node_modules and package.json must be managed together so that package.json is consistent with what node_modules contains, or else, npm may not work properly. As it is important to ignore node_modules, is also important to ignore package-lock.json.
|
The documentation you linked explicitly states "This file is intended to be committed into source repositories". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application of the change:
The change is made in VisualStudio.gitignore for Node.js Tools for Visual Studio
Reasons for making this change:
package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree or package.json. That is why node_modules and package.json must be managed together so that package.json is consistent with what node_modules contains, or else, npm may not work correctly. As it is essential to ignore node_modules, it is also vital to ignore package-lock.json.
Links to documentation supporting these rule changes:
Documentation about package-lock.json: https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json