Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add '/out' to ignore file for Visual Studio #2994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lukka
Copy link

@lukka lukka commented Mar 13, 2019

Add "/out" to ignored directory for Visual Studio CMake configuration templates in CMakeSettings.json

Reasons for making this change:

Default build directory for CMake configuration of VS are going to use 'out' under of the opened folder

Links to documentation supporting these rule changes:

Doc will be released after the release of VS Preview.

@lukka
Copy link
Author

lukka commented Apr 3, 2019

@shiftkey any comment on this PR? thanks

@shiftkey
Copy link
Member

@lukka my current thinking on this is that we should be using the CMake.gitignore template for any rule changes, rather than duplicating rules across templates.

@lukka
Copy link
Author

lukka commented Apr 23, 2019

@shiftkey I agree with you, however in this case the default output directory for binaries in the CMakeSettings.json file (consumed by Visual Studio, not by CMake) will contains a path like:

"buildRoot": "${projectDir}\\out\\build\\${name}"

hence it would be nice if the .gitignore for VS would already ignore it.

@lukka
Copy link
Author

lukka commented Jan 22, 2020

Any follow up please?

@lukka
Copy link
Author

lukka commented Apr 21, 2020

Knock knock

@TheJCAB
Copy link

TheJCAB commented Aug 28, 2020

I wholeheartedly agree with this change. I just reported the issue, with my rationale, on devcomm here: https://developercommunity.visualstudio.com/content/problem/1164532/the-cmake-project-template-puts-build-artifacts-in.html

The "out" directory used by VS for CMake projects is in line with many of the entries in this file. CMake.gitignore just lists a number of files used/generated by CMake. OTOH, this PR adds an entry to remove the entire VS-defined directory tree of build-generated files (generated by CMake, and by the build tools used under it).

@jumattos
Copy link

jumattos commented Oct 1, 2020

Documentation supporting this pull request is out. See CMake projects in Visual Studio - IDE Integration.

Click the Show All Files button at the top of Solution Explorer to see all the CMake-generated output in the out/build/ folders.

Reconsider this PR. Alternatively, I created a new one that adds "out" to build results: #3540

@lukka
Copy link
Author

lukka commented Dec 7, 2020

After more than 1 year, is there going any action taken on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants