Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect indentation in managing-a-custom-domain-for-your-github-pages-site.md #22241

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Fix incorrect indentation in managing-a-custom-domain-for-your-github-pages-site.md #22241

merged 4 commits into from
Nov 23, 2022

Conversation

Marcono1234
Copy link
Contributor

Why:

Closes #22180

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixes incorrect indentation of the note. Previously it was not indented and would cause the list to be split, with the next item starting at "1." again, see also description of #22180.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Marcono1234
Copy link
Contributor Author

Now the list numbering seems to be correct, but Markdown rendering is broken for this note:
Broken Markdown screenshot

Maybe this is also only an intermittent issue like the broken rendering in #22180, though that is really weird then. I am seeing this in Firefox and Edge, both in private windows, so I don't think this is caused by the browser cache (?).

@cmwilson21
Copy link
Contributor

@Marcono1234 Thanks for opening a PR! I'll get this triaged for review ⚡

As for the markdown in the note, I followed your advice with Firefox and a private browser and have been unable to recreate it. Perhaps you are right and it was a temp bug or it may have been fixed in an internal PR. Either way, thanks for the heads up about it! ✨

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Nov 23, 2022
Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Marcono1234 ⚡ I'm going to make a small edit, and then I'll merge this.

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on preview now. 🎉

I'll go ahead and get this PR merged, thanks again @Marcono1234 !

@vgrl vgrl enabled auto-merge November 23, 2022 22:25
@vgrl vgrl merged commit 52dd0be into github:main Nov 23, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Marcono1234 Marcono1234 deleted the patch-1 branch November 24, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Manage a custom domain" > "Configuring a subdomain" has broken formatting
3 participants