-
Notifications
You must be signed in to change notification settings - Fork 58.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken #syntax-exceptions link #20541
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
@mLuby Thanks for opening a PR and linking to your issue. We also appreciate all the great details you've provided! ✨ Good catch on this one. I'll get it triaged for review! 👀 |
👋 @mLuby - After looking at this and chatting with the team, I think we would like to see a different approach here. We appreciate your solution, but would like to see this warning box moved to the top of this sub section for better visibility and remove the inline link in question. Would you be up for that?
If not, let me know and we will take care of it internally. Thanks again for catching this! ⚡ |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Thanks for bringing this up and offering your clever fix. I made some tweaks so that it aligned better with our style guide. I'll get this merged once the tests have passed ✅ Thank you for interest in improving the docs! 💛 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #20540
Fixes the link
[some exceptions](#syntax-exceptions)
from earlier in the doc which currently doesn't go anywhere, since it was broken by the recent change 384473f.What's being changed (if available, include any code snippets, screenshots, or gifs):
This change re-adds a minor header to the Code owners doc's syntax exceptions warning block so the link to that area will again work as intended.
Note to reviewers: the Preview doesn't render the warning block, so I can't tell if the header conflicts with the non-Markdown warning block.
Check off the following:
Writer impact (This section is for GitHub staff members only):