Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: query to detect implicitly exported Android components #9983

Merged
merged 26 commits into from
Aug 24, 2022

Conversation

jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented Aug 5, 2022

This PR adds a query to detect implicitly exported components in AndroidManifest.xml files.

@jcogs33 jcogs33 changed the title Android implicit export Java: query to detect implicitly exported Android components Aug 8, 2022
@jcogs33 jcogs33 force-pushed the android-implicit-export branch 3 times, most recently from fcf929a to 560b4ec Compare August 10, 2022 20:30
@jcogs33 jcogs33 marked this pull request as ready for review August 12, 2022 17:49
@jcogs33 jcogs33 requested a review from a team as a code owner August 12, 2022 17:49
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 😄

Added a couple of minor comments.

@jcogs33 jcogs33 added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Aug 19, 2022
@saritai
Copy link
Contributor

saritai commented Aug 19, 2022

👋 Hello, Docs Content first responder here! I have added this PR to our writer review board to be picked up to review in the next couple days! Thanks!

@mchammer01 mchammer01 self-requested a review August 22, 2022 09:02
mchammer01
mchammer01 previously approved these changes Aug 22, 2022
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcogs33 👋🏻 - this LGTM ✨
I have made a suggestion about the query description, but I leave it up to you whether you can find a better alternative.

mchammer01
mchammer01 previously approved these changes Aug 22, 2022
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from an editorial perspective :shipit:

@jcogs33 jcogs33 merged commit b3e88f8 into github:main Aug 24, 2022
@jcogs33 jcogs33 deleted the android-implicit-export branch August 24, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Java ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants