Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Convert Revel and net/http sources to MaD #16986

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 16, 2024

Go: Convert Revel and net/http sources to MaD.

I don't believe it needs a change note.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 16, 2024
@owen-mc owen-mc requested a review from a team as a code owner July 16, 2024 10:48
@github-actions github-actions bot added the Go label Jul 16, 2024
@owen-mc owen-mc requested a review from egregius313 July 16, 2024 10:49
Copy link
Contributor

github-actions bot commented Jul 16, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `Revel <http:https://revel.github.io/>`_,"``github.com/revel/revel*``, ``github.com/robfig/revel*``",,20,
+    `Revel <http:https://revel.github.io/>`_,"``github.com/revel/revel*``, ``github.com/robfig/revel*``",42,20,
-    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",8,584,
+    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",16,584,
-    Totals,,154,898,24
+    Totals,,204,898,24
  • Changes to framework-coverage-go.csv:
- github.com/revel/revel,,,10,,,,10,
+ github.com/revel/revel,,21,10,,,21,10,
- github.com/robfig/revel,,,10,,,,10,
+ github.com/robfig/revel,,21,10,,,21,10,
- net/http,,8,22,,,8,22,
+ net/http,,16,22,,,16,22,

@owen-mc owen-mc force-pushed the go/mad-sources-revel-nethttp branch from 80bda97 to 535b4ea Compare July 16, 2024 15:53
Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-mc owen-mc merged commit 12fe998 into github:main Jul 16, 2024
13 checks passed
@owen-mc owen-mc deleted the go/mad-sources-revel-nethttp branch July 16, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants