C#/Java: Parameterized module for model printing. #16775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,72 +1,11 @@ | |||
| private import CaptureModelsSpecific | |||
| private import csharp as CS | |||
Check warning
Code scanning / CodeQL
Names only differing by case Warning
michaelnebel
force-pushed
the
modelgen/refactorprinting
branch
from
9fce72c
to
8edc3d3
Compare
michaelnebel
force-pushed
the
modelgen/refactorprinting
branch
from
8edc3d3
to
4cf1062
Compare
michaelnebel
added
the
no-change-note-required
|
DCA looks good! |
owen-mc
previously approved these changes
Jun 19, 2024
michaelnebel
force-pushed
the
modelgen/refactorprinting
branch
from
4cf1062
to
9cd16fd
Compare
hvitved
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we convert the model printing module from a pyrameterized module into a parameterized module.
This avoids syncing at least one part of the model generator implementation.