-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LoC metrics from the analysis summary #14811
Remove LoC metrics from the analysis summary #14811
Conversation
Reviewers, do you think this change should have a changenote? |
No. There is no change to query results, or to our QL libraries. |
I'd say so, yes. Not sure if it should be a CLI change note, though? |
Are you referring to this bit?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for Python
Agreed that if you want to add a change-note, it should go to the CLI (or action) |
@henrymercer I'm not able to find this information anywhere for javascript-typescript. I see it in Java CodeQL jobs. When I view the coverage page as described above it just shows file counts not LOC? Where can I find this data for javascript-typescript? |
Currently for C/C++, JavaScript/TypeScript, and Python, we print a table like the following after analyzing the database:
We want to stop printing this lines of code information now that we have replaced it by file coverage information. We have already removed queries tagged
lines-of-code
from the analysis summary, but C/C++, JavaScript/TypeScript, and Python define both lines of code and lines of user code queries, and only the lines of user code queries are taggedlines-of-code
. Therefore, this PR tags the lines of code queries withtelemetry
to remove them from the analysis summary, while preserving the metric data in the SARIF file for advanced users.