Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare shared type tracking library for adoption by Ruby #14710

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Prepare shared type tracking library for adoption by Ruby #14710

merged 3 commits into from
Nov 16, 2023

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 7, 2023 •
edited
Loading

  • Cache relevant predicates.
  • Expose some predicates and classes (only exposed internally).
  • Make some top-level inline_late predicates member predicates.
  • Actually eliminate type check in flowsTo.
  • Fix bug in getACompatibleTypeTracker.
  • Adopt the CallGraphConstruction module.

@github-actions github-actions bot added the Java label Nov 7, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 8, 2023
@hvitved hvitved marked this pull request as ready for review November 8, 2023 09:15
@hvitved hvitved requested a review from a team as a code owner November 8, 2023 09:15
@hvitved
Copy link
Contributor Author

hvitved commented Nov 8, 2023

This PR appears to have a positive performance impact on apache__commons-math and palatable__lambda; presumably because of the added caching, which will ultimately make uses of the SimpleGlobal library faster.

@github-actions github-actions bot removed the Java label Nov 15, 2023
@hvitved
Shared: Split up TypeTracking.qll into two files
f66f7ce
@hvitved
Shared: Port features from Ruby's type tracking library to the shared…
5f087f0 
… library

- Cache relevant predicates.
- Expose some predicates and classes (only exposed internally).
- Make some top-level `inline_late` predicates member predicates.
- Actually eliminate type check in `flowsTo`.
- Fix bug in `getACompatibleTypeTracker`.
- Adopt the `CallGraphConstruction` module.
@hvitved
Shared: Update type tracking consistency checks
57f6859
aschackmull
aschackmull approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hvitved hvitved merged commit 6bba191 into github:main Nov 16, 2023
15 checks passed
@hvitved hvitved deleted the type-tracking/prepare-ruby branch November 16, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aschackmull