Go: Two fixes to upper bound checks in "incorrect integer conversion" query #14606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is the possibility of overflow.
|
Performance testing showed no significant change |
smowton
previously approved these changes
Oct 27, 2023
owen-mc
force-pushed
the
go/incorrect-integer-conversion-fixes
branch
from
fe2d463
to
3c9783c
Compare
owen-mc
changed the title
smowton
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs fixed, with corresponding test cases, plus some miscellaneous refactoring to make some of the code a bit nicer to read and to try to avoid doing integer arithmetic with floats (because CodeQL integers are signed 32-bit integers) above the level where that is precise.