Python: New FileSystem Access

[am0o0]

No description provided.

[RasmusWL]

Thanks for this PR 🙏 💪 The modeling you've added looks good, and thanks for adding tests that use the ConceptsTest setup 🙌

The one major thing I need from you is to restructure the modeling. So far we've kept an (unwritten) policy of using one .qll file for each library we've modeled, so while it's a little less boilerplate code to group them together in FileSystemAccess.qll, I would like you to split them into separate .qll files (anyio, aiofile).

I'm going to add a change-note to highlight this modeling 👍

[am0o0]

@RasmusWL do you think there is a need to add a query file to just add a small framework that just has less than 10 functions total? I'm just curious about this I'll make changes according to your review.

[RasmusWL]

@RasmusWL do you think there is a need to add a query file to just add a small framework that just has less than 10 functions total? I'm just curious about this I'll make changes according to your review.

please do all .qll files (like you did for python/ql/lib/semmle/python/frameworks/Cherrypy.qll), don't add any query (.ql) files

[am0o0]

please do all .qll files (like you did for python/ql/lib/semmle/python/frameworks/Cherrypy.qll), don't add any query (.ql) files

Ahh sorry, I wrongly wrote the query file instead of the library file.

@RasmusWL do you think there is a need to add a library file to add a small framework that only has less than 10 functions total? I'm just curious about this I'll make changes according to your review.

[RasmusWL]

@RasmusWL do you think there is a need to add a library file to add a small framework that only has less than 10 functions total? I'm just curious about this I'll make changes according to your review.

Yes, please do. I know it's a little more boilerplate code, but I would like to keep our structured approach for now 🙏

[RasmusWL]

Thanks for making these changes 🙌 great work 👍

[RasmusWL]

With that little thing fixed, I think we're good to go overall 👍 (will just do a performance test as well for good measure)

[RasmusWL]

Performance looks fine 👍