Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: deprecate AST-based GVN #11262

Merged
merged 2 commits into from
Nov 21, 2022
Merged

C++: deprecate AST-based GVN #11262

merged 2 commits into from
Nov 21, 2022

Conversation

rdmarsh2
Copy link
Contributor

No description provided.

@rdmarsh2 rdmarsh2 requested a review from a team as a code owner November 14, 2022 21:54
@jketema
Copy link
Contributor

jketema commented Nov 15, 2022

Coding standards fix: github/codeql-coding-standards#138

MathiasVP
MathiasVP reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. We need to accept the changes to .expected files, though.

@jketema
Copy link
Contributor

jketema commented Nov 18, 2022

Coding standards fix

This has been merged. Coding standards tests now pass.

@jketema jketema merged commit 78ad9ba into github:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdmarsh2 @jketema @MathiasVP