Swift: Move the Unit class to its own file #11096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
force-pushed
the
atorralba/swift/unit
branch
from
82d79d6
to
4c2a6da
Compare
MathiasVP
reviewed
Nov 3, 2022
| @@ -1,9 +1,14 @@ | |||
| /** | |||
| * Provides Swift-specific definitions for use in the data flow library. | |||
| */ | |||
|
|
|||
| import swift as Swift | |||
There was a problem hiding this comment.
Yep, just realized it 😅 Fixed in 978ed03, thanks for pointing it out.
atorralba
force-pushed
the
atorralba/swift/unit
branch
from
4c2a6da
to
978ed03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the necessity of importing an internal dataflow file to be able to use the
Unitclass.