Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide error message and stack for non-error #1485

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jan 17, 2023

Avoid printing the error message and stack when we fail to find the commit. This will happen in several non-error states (e.g., when there is no repository checked out at the CWD). Move the error message to a debug message so that it is still available if someone really wants to see it.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Avoid printing the error message and stack when we fail to find the
commit. This will happen in several non-error states (e.g.,
when there is no repository checked out at the CWD). Move the
error message to a debug message so that it is still available
if someone really wants to see it.
@aeisenberg aeisenberg requested a review from a team as a code owner January 17, 2023 23:02
src/actions-util.ts Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

@angelapwen Thanks for your review. Can you re-approve?

Co-authored-by: Angela P Wen <[email protected]>
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look unrelated to the CI failures to me — are we failing CI on main?

@aeisenberg
Copy link
Contributor Author

Yep. Failing on main. Checking on this now.

@aeisenberg aeisenberg merged commit 40cfcb0 into main Jan 18, 2023
@aeisenberg aeisenberg deleted the aeisenberg/comitoid-message branch January 18, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants